Add support for Atziri's Splendour mana to life cost conversion for corrupted gems#2312
Open
slaren wants to merge 2 commits into
Open
Add support for Atziri's Splendour mana to life cost conversion for corrupted gems#2312slaren wants to merge 2 commits into
slaren wants to merge 2 commits into
Conversation
slaren
commented
Jun 27, 2026
| { stat = "BrandAttachmentRangeMetre", label = "Attachment Range", fmt = ".1fm", flag = "brand" }, | ||
| { stat = "BrandTicks", label = "Activations per Brand", fmt = "d", flag = "brand" }, | ||
| { stat = "ManaCost", label = "Mana Cost", fmt = "d", color = colorCodes.MANA, pool = "ManaUnreserved", compPercent = true, lowerIsBetter = true, condFunc = function(v,o) return o.ManaHasCost end }, | ||
| { stat = "ManaCost", label = "Mana Cost", fmt = ".0f", color = colorCodes.MANA, pool = "ManaUnreserved", compPercent = true, lowerIsBetter = true, condFunc = function(v,o) return o.ManaHasCost end }, |
Author
There was a problem hiding this comment.
This is somewhat unrelated, but while working on this I noticed that the mana cost display was not being rounded, so in some cases it would be off by one when compared to the in-game tooltip.
Blitz54
reviewed
Jun 28, 2026
Comment on lines
+697
to
+699
| if activeEffect.srcInstance and activeEffect.srcInstance.corrupted then | ||
| activeSkill.skillCfg.skillCond["GemCorrupted"] = true | ||
| end |
Contributor
There was a problem hiding this comment.
Could this be moved to line 771? As it's already checking for corrupted there.
if activeSkill.activeEffect.srcInstance and activeSkill.activeEffect.srcInstance.corrupted and not (activeSkill.activeEffect.srcInstance.fromItem or activeSkill.activeEffect.srcInstance.fromTree or activeSkill.activeEffect.grantedEffect.fromItem or activeSkill.activeEffect.grantedEffect.fromTree) then
skillModList:NewMod("GemCorruptionLevel", "BASE", activeSkill.activeEffect.srcInstance.corruptLevel, "Corruption")
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The mod "Skills from Corrupted Gems have 50% of Mana Costs Converted to Life Costs" from Atziri's Splendour is not supported.
Steps taken to verify a working solution:
I am not sure if this is the best way to add the "GemCorrupted" condition, any feedback is appreciated.